Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.11] Restore graceful shutdown of DNS server #21021

Merged
merged 1 commit into from
Sep 19, 2018
Merged

[release-3.11] Restore graceful shutdown of DNS server #21021

merged 1 commit into from
Sep 19, 2018

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Sep 18, 2018

Restore signal handling and graceful shutdown of DNS that had been added in commit c802e22 but was subsequently lost during rebase in commit 564ee03.

Graceful shutdown is necessary to ensure that when OpenShift's DNS server shuts down, we remove it from the dnsmasq configuration.

This commit fixes bug 1624448.

https://bugzilla.redhat.com/show_bug.cgi?id=1624448

This is a manual cherry-pick of #21009

@Miciah
Restore graceful shutdown of DNS server
4c6c0eb 
Restore signal handling and graceful shutdown of DNS that had been added in
commit c802e22 but was subsequently lost
during rebase in commit 564ee03.

Graceful shutdown is necessary to ensure that when OpenShift's DNS server
shuts down, we remove it from the dnsmasq configuration.

This commit fixes bug 1624448.

https://bugzilla.redhat.com/show_bug.cgi?id=1624448
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2018
@Miciah
Copy link
Contributor Author

Miciah commented Sep 18, 2018

/retest

@Miciah
Copy link
Contributor Author

Miciah commented Sep 18, 2018

/retest

Seen this error from docker login in test/end-to-end/core.sh a couple times now:

Error response from daemon: login attempt to http://172.30.1.1:5000/v2/ failed with status: 500 Internal Server Error

@Miciah
Copy link
Contributor Author

Miciah commented Sep 18, 2018

Same docker login failure.

/retest

@Miciah
Copy link
Contributor Author

Miciah commented Sep 18, 2018

/retest

1 similar comment
@knobunc
Copy link
Contributor

knobunc commented Sep 18, 2018

/retest

@ironcladlou
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2018
@ironcladlou
Copy link
Contributor

/retest

@Miciah
Copy link
Contributor Author

Miciah commented Sep 18, 2018

I opened BZ#1630537 e2e flake: docker login to internal registry fails with "500 Internal Server Error" for the end-to-end test flake.

@knobunc
Copy link
Contributor

knobunc commented Sep 18, 2018

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2018
@knobunc
Copy link
Contributor

knobunc commented Sep 18, 2018

@smarterclayton Can I green box merge this? There seems to be some flake killing the tests and it must be in for QE tonight.

pravisankar
pravisankar approved these changes Sep 18, 2018
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, knobunc, Miciah, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@Miciah: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/end_to_end 4c6c0eb link /test end_to_end

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knobunc knobunc merged commit e3ff49a into openshift:release-3.11 Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravisankar pravisankar pravisankar approved these changes

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@ironcladlou ironcladlou

@pravisankar pravisankar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Miciah @knobunc @ironcladlou @openshift-ci-robot @openshift-bot @pravisankar